Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR enables compression the
loki.write
WAL. Both snappy and zstd are supported by the reader/writer side, and the reader side checks the compression of each record read (so no compat issues). Snappy was picked because since this it will be used in a WAL, rather than a wire-protocol, we strive more for cpu efficiency (snappy is cpu lighter) rather higher compression rate (which zstd does better, but at a higher CPU cost).Enabling compression in WAL allowed us in our agents deployment to have a compression rate of ~2.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist