Remove deprecated otelcol.exporter.jaeger #5171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hainenber
force-pushed
the
remove-otelcol-exporter-jaeger
branch
from
bb505f2 to
ebee34b
Compare
hainenber
changed the title
|
Hey @hainenber, thanks for the PR! We're not going to be able to merge this until we're working on the v0.38 release, since that's when we said we'd remove the deprecated component (we shouldn't remove deprecated things earlier than we said we would). We'll leave this PR open for now and merge it after v0.37 is released and the v0.38 development cycle starts. |
|
Thanks for the heads-up, guess I still have time to fix the failed tests from the removal 😅 |
clayton-cornell
added
the
type/docs
hainenber
force-pushed
the
remove-otelcol-exporter-jaeger
branch
from
f3abb4d to
4947434
Compare
|
Hey @hainenber, we're working on the v0.38 cycle now so we can merge this PR once the merge conflicts are resolved and the CI is green :) |
Signed-off-by: hainenber <[email protected]>
hainenber
force-pushed
the
remove-otelcol-exporter-jaeger
branch
from
4947434 to
4e5b17e
Compare
|
I don't know why this PR is causing unrelated tests to flake, but I'm looking into it so we can get this merged. |
Iterate over labels consistently
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Fixes #5138
Notes to the Reviewer
PR Checklist