config-reloader: change to non-root user #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jcreixell
reviewed
Jun 30, 2023
| operatorContainers := []core_v1.Container{ | ||
| { | ||
| Name: "config-reloader", | ||
| Image: imagePathConfigReloader, | ||
| VolumeMounts: volumeMounts, | ||
| Env: envVars, | ||
| SecurityContext: &core_v1.SecurityContext{ | ||
| RunAsUser: pointer.Int64(0), |
There was a problem hiding this comment.
@rfratto is there a specific reason why this was initially configured to run as root? do you see any problems with this?
There was a problem hiding this comment.
Probably just me being aggressive with copy and paste, I think it's safe to remove.
rfratto
approved these changes
Nov 3, 2023
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Force the
config-reloadercontainer to run as root is not practical in platform that are under rigorous security constraints (ex: Openshift).Unless I am missing a specific situation, I suggest to setup the security context of this container, the same way the Prometheus Operator does. See prometheus-operator/prometheus-operator config_reloader.go#L256-L262
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist