Conflicting router patterns when built with Go 1.23

[stefanb]

What's wrong?

Conflicting patterns detected when built with Go 1.23

$ grafana-agent --version
  panic: pattern "GET /debug/pprof/" (registered at net/http/pprof/pprof.go:100) conflicts with pattern "/debug/pprof/delta_heap" (registered at github.com/grafana/pyroscope-go/[email protected]/http/pprof/pprof.go:24):
  	GET /debug/pprof/ matches fewer methods than /debug/pprof/delta_heap, but has a more general path pattern

Steps to reproduce

When runing the tests for Homebrew/homebrew-core#175310 the Grafana agent test failed with:

  ==> Testing grafana-agent
  ==> /opt/homebrew/Cellar/grafana-agent/0.41.1/bin/grafana-agent --version
  panic: pattern "GET /debug/pprof/" (registered at net/http/pprof/pprof.go:100) conflicts with pattern "/debug/pprof/delta_heap" (registered at github.com/grafana/pyroscope-go/[email protected]/http/pprof/pprof.go:24):
  	GET /debug/pprof/ matches fewer methods than /debug/pprof/delta_heap, but has a more general path pattern
  
  goroutine 1 [running]:
  net/http.(*ServeMux).register(...)
  	net/http/server.go:2805
  net/http.HandleFunc({0x14000074e70?, 0x10587ac8a?}, 0x107723ea0?)
  	net/http/server.go:2799 +0x9c
  net/http/pprof.init.0()
  	net/http/pprof/pprof.go:100 +0x94

System information

All, irrelevant

Software version

Grafana Agent v0.41.1

Configuration

No response

Logs

No response

[stefanb]

There were some changes in the routing patterns according to https://tip.golang.org/doc/go1.23#nethttppkgnethttp

The patterns used by ServeMux now allow one or more spaces or tabs after the method name. Previously, only a single space was permitted.

...but this should not cause such error.

[gizmoguy]

Fixed in https://github.com/grafana/pyroscope-go/releases/tag/godeltaprof%2Fv0.1.8 by grafana/pyroscope-go@edd64fd

[llamafilm]

I got a very similar error trying to run Grafana Alloy with go 1.23. It works fine with go 1.22.

goroutine 1 [running]:
net/http.(*ServeMux).register(...)
net/http/server.go:2797
net/http.HandleFunc({0x14001af9800?, 0x109b3a330?}, 0x10baec9c0?)
net/http/server.go:2791 +0x9c
net/http/pprof.init.0()
net/http/pprof/pprof.go:100 +0x94
panic: pattern "GET /debug/pprof/" (registered at net/http/pprof/pprof.go:100) conflicts with pattern "/debug/pprof/delta_heap" (registered at [github.com/grafana/pyroscope-go/](http://github.com/grafana/pyroscope-go/)[[email protected]](mailto:[email protected])/http/pprof/pprof.go:24):
GET /debug/pprof/ matches fewer methods than /debug/pprof/delta_heap, but has a more general path pattern

[github-actions]

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

[daurnimator]

This is preventing the bump of grafana-agent in Arch Linux

[rvdheij]

I tried to build 11.2.5 with go version 1.22 and see that it fails to build with

go: go.work requires go >= 1.22.7 (running go 1.22.1; GOTOOLCHAIN=local)

With go = 1.22.7 it builds again.