Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash at initialization when compiling with go 1.23 #158

Closed
rnestler opened this issue Sep 16, 2024 · 3 comments
Closed

Crash at initialization when compiling with go 1.23 #158

rnestler opened this issue Sep 16, 2024 · 3 comments

Comments

@rnestler
Copy link

When compiling nctl with go 1.23 I get the following panic at startup:

panic: pattern "GET /debug/pprof/" (registered at net/http/pprof/pprof.go:100) conflicts with pattern "/debug/pprof/delta_heap" (registered at github.com/grafana/pyroscope-go/[email protected]/http/pprof/pprof.go:24):
	GET /debug/pprof/ matches fewer methods than /debug/pprof/delta_heap, but has a more general path pattern

grafana/agent#6972 and grafana/alloy#1540 seem to be the same error.

It seems to be fixed in https://github.com/grafana/pyroscope-go/releases/tag/godeltaprof%2Fv0.1.8

@rnestler
Copy link
Author

I think it was already fixed in 0c54c5b so only a release is necessary.

@thirdeyenick
Copy link
Contributor

We just released version 1.74 which fixes this issue. Thanks for reporting!

@rnestler
Copy link
Author

Thanks, seems to fix it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants