forked from cornerstonejs/cornerstone3D
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradient rebase 12212023 #6
Open
Adithyan-Dinesh-Trenser
wants to merge
163
commits into
gradienthealth/dicom-zip-image-loader
Choose a base branch
from
gradient_rebase_12212023
base: gradienthealth/dicom-zip-image-loader
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Gradient rebase 12212023 #6
Adithyan-Dinesh-Trenser
wants to merge
163
commits into
gradienthealth/dicom-zip-image-loader
from
gradient_rebase_12212023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line (cornerstonejs#802) * add arcs * move lines separately * update api * dont change demo * fix * update to cached stats * update api * update api * revert
…ejs#834) * Implementing colormap in stack viewport properties * setColormap private + example * api update * vtk colomaps * fix reset button + adding properties for volume * added slabthickness to properties + update example * small fix setColormapGPU * fix voiRange for volume * Mapping properties for volumeID * small fix * fix undefined properties * properties by image index * api updates * refactoring VOI + about comments * update imageIndex to imageId + doc changes * update api's * remove from basic example * refacto + voiUpdateWithSetproperties back * refactoring volume viewport properties * re-add PTPrescaled * fix * fix documentation * api checks * try * remove dummy file * fix api check * fix demo * update examples * api * api * enable reset color map via resetproperties * bug * api * api --------- Co-authored-by: Celian-abd <[email protected]> Co-authored-by: Salim Kanoun <[email protected]>
…cornerstonejs#835) * fix(getDataInTime): to consider different image spacing for reference * apply review comments
…entation (cornerstonejs#808) * feat: add surface segmentation representation * fix examples * revert * rename * webpack * webpack * Add surface clipping via filter * Reset camera clipping range * refactor how viewport updates clipping planes * Add polydata cache * Add event for clipping planes update * Stack surface example created * Refactor imageSlice creation * fix polydata not showing in stack * Adding a RT stack example * Create SegmentationIntersectionTool * fix * Remove duplicate points * Fix color bug and remove duplicate points * Fix bug multiple polylines * Refactor unwanted canAdded planes variable * Restore file * Add comments in changed files * minor refactoring to build and update api * Fix minor regression bug * cleanup * wip * wip * cleanup * fix the performance issue with zoom and pan revisiting same slice * fix reconstructed views * api * demo * doc * fix vtk actors --------- Co-authored-by: Alireza <[email protected]>
…ornerstonejs#841) * fix bugs * exports * api
Co-authored-by: Ouwen Huang <[email protected]>
…r decoding (cornerstonejs#667) * fix multiframe index problem * fix non scaled pt window level lazyniess * build api * apply review comments * fix(multiframe): use portion of array buffer to send to webworker * fix the place to put the options * add more docs * update api * update api * review comments * fix crossharis example * bugs
…js#815) * Fix issue with Enums.RequestType * api extractor * Add an interface for ImageLoadRequests * remove unnecessary export * PR feedback --------- Co-authored-by: Mathieu <[email protected]>
* feat(colorBar): added color bar component * restore point * changed color bar example page * code review * Fixeds interaction (mouse events + windowlevel tool) * code review * renamed [Cc]olorBar to [Cc]olorbar * added some comments * code review * moved 'widgets' to a different folder * example :: renamed 'Color Bar' to 'colorbar' * updated colorbar example for volume and stack viewports * fixed build * update-api
…js#851) * fix(colorbar): fixed the position of the ticks that was broken after scrolling down * feat(colorbar): improved colorbar example - Colormap dropdowns added per viewport - Stack viewport have 1 dropdown and both volume viewports have 2 each * feat(colorbar): basic colorbar example + fixed colobar size * updated examples info (json)
* fix import * remove
) * feat(RenderingEngine): Enhance camera initialization logic Improved camera setup process within the RenderingEngine's volume viewport components, making initial camera view up configuration adjustable by subclasses and aligning view up initialization with camera reset logic. Standardized calculation of camera view up angles for consistency and potentially clearer subclass overrides. * update api
… and probe tool to better support US (cornerstonejs#927) * update * Fix length measurement calculation and handle calibrated units in LengthTool * Refactor getCalibratedUnits.ts to improve code readability and maintainability * Fix ultrasound enhanced region bug * Fix length and probe tool calibration * Add UltrasoundDirectionalTool and drawHandle function * Fix unit comparison bug in UltrasoundDirectionalTool * Remove unused code and improve calculation of projected point canvas in UltrasoundDirectionalTool * Refactor ultrasoundEnhancedRegion/index.ts and ProbeTool.ts * Refactor ultrasoundEnhancedRegion/index.ts and ProbeTool.ts * Add Ultrasound Directional Tool and update tool API * example * Fix conditional check for image calibration * update based on review * fix representation issue * feat(ultrasound): Add toggle button to display both axes distances Add a toggle button to the ultrasound directional tool's toolbar that allows users to display both horizontal and vertical distances. Previously, only one distance was displayed based on the orientation of the tool. This enhancement provides users with more comprehensive measurement information for ultrasound annotations. Summarized changes: - Added a new function to add a toggle button to the toolbar in the ultrasoundEnhancedRegion example - Updated the UltrasoundDirectionalTool class to handle the toggle button's onClick event and modify the tool configuration accordingly - Modified the defaultGetTextLines function to display both horizontal and vertical distances when the toggle button is enabled - Updated the UltrasoundDirectionalAnnotation interface to include new properties for storing distances along both axes This change improves the usability of the ultrasound directional tool by enhancing the measurement capabilities and providing more informative annotation details. * update * api * feat(calibration-logic): Enhance ultrasound region calibration Enhanced the logic for determining calibrated units and scales in ultrasound imaging regions. Now, the system filters for supported regions more effectively and accounts for regions with different physical deltas in the X and Y directions. If deltas differ, pixel units are utilized, ensuring relevant calibration is always displayed. Additionally, consolidated filter and support checks, extracting units and scales based on updated conditions. This update improves the accuracy and reliability of unit calibration across different imaging scenarios. * remove bun lock * feat(calibration): Ensure unit consistency in measurements Improved calibration logic to consistently use absolute values when comparing deltas, ensuring the correct units are displayed depending on whether deltas are equal. This change enhances measurement accuracy for the US region calibration in the utility function.
* Overrided the Normalizer to supports single slice segmentation. * Exported the loadZiprequest function * Support for segmentation level visibility in stack segmentation. * Refactoring the changes. * Code optimization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.