Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operation test on the creation of pipeline layout with null bind group layout #4116

Merged
merged 8 commits into from
Jan 9, 2025

Conversation

Jiawei-Shao
Copy link
Collaborator

@Jiawei-Shao Jiawei-Shao commented Dec 23, 2024

Issue: #4075


Requirements for PR author:

  • [*] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [*] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [*] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • [*] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Copy link
Contributor

@jiangzhaoming jiangzhaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note, Jiawei is working on fixing issue caught by the test.

@kainino0x
Copy link
Collaborator

Fixed: #4075

Do we still need to fix the tests suppressed in https://dawn-review.googlesource.com/c/dawn/+/220534 or are they fixed already?
(Not that we'll probably forget about them, but good to keep an issue open if work still needs to be done.)

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from testing empty bind groups

@Jiawei-Shao
Copy link
Collaborator Author

Fixed: #4075

Do we still need to fix the tests suppressed in https://dawn-review.googlesource.com/c/dawn/+/220534 or are they fixed already? (Not that we'll probably forget about them, but good to keep an issue open if work still needs to be done.)

Yes. I'll fix them in the next patch.

Copy link
Contributor

@jiangzhaoming jiangzhaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@Jiawei-Shao Jiawei-Shao merged commit b5532d4 into gpuweb:main Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants