-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add operation test on the creation of pipeline layout with null bind group layout #4116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a note, Jiawei is working on fixing issue caught by the test.
src/webgpu/api/operation/pipeline/pipeline_layout_created_with_null_bind_group_layout.spec.ts
Outdated
Show resolved
Hide resolved
Do we still need to fix the tests suppressed in https://dawn-review.googlesource.com/c/dawn/+/220534 or are they fixed already? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from testing empty bind groups
src/webgpu/api/operation/pipeline/pipeline_layout_created_with_null_bind_group_layout.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/operation/pipeline/pipeline_layout_created_with_null_bind_group_layout.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/operation/pipeline/pipeline_layout_created_with_null_bind_group_layout.spec.ts
Outdated
Show resolved
Hide resolved
Yes. I'll fix them in the next patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Issue: #4075
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.