-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test using a pipeline created with null bind group layout #4113
Test using a pipeline created with null bind group layout #4113
Conversation
Since all cases are expected to success, is it possible to merge this new tests into the previous one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After second thought, we are testing two things if test cases merged (creating pipeline vs setting bind group), so it might be good to keep as separated tests (despite of some duplicated codes)?
@kainino0x What do you think? Sorry for troubling...
I haven't had a chance to actually review this (and I'm going on break - apologies). |
This reverts commit 8bbc5e8.
…awei-Shao/cts into test-pipeline-null-bgl-set-bg
Done |
The failure is not related to my PR. PTAL, thanks! |
I proposed web-platform-tests/wpt#49823 to fix the CI workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks
Thanks a lot for your fix! @jzm-intel |
This patch adds validation tests on the use of a render pipeline or a compute pipeline
created with null bind group layouts. Note that as the total amount of the sub cases
(32) is not that large both
null
andundefined
are tested in these tests.Issue: #4075
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.