chore: add add_dataset_elements function #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <[email protected]>
g-linville
requested review from
drpebcak,
thedadams,
njhale,
StrongMonkey,
iwilltry42 and
tylerslaton
drpebcak
approved these changes
Oct 30, 2024
thedadams
requested changes
Oct 30, 2024
| @@ -270,6 +270,30 @@ async def add_dataset_element(self, workspace_id: str, datasetID: str, elementNa | |||
| ) | |||
| return DatasetElementMeta.model_validate_json(res) | |||
|
|
|||
| async def add_dataset_elements(self, workspace_id: str, datasetID: str, elements: List[DatasetElement]) -> str: | |||
There was a problem hiding this comment.
workspace_id should be optional
Suggested change
| async def add_dataset_elements(self, workspace_id: str, datasetID: str, elements: List[DatasetElement]) -> str: | |
| async def add_dataset_elements(self, datasetID: str, elements: List[DatasetElement], workspace_id: str = "") -> str: |
thedadams
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.