Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parameter to the command to set the redirect URL after auth #404

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

pacoorozco
Copy link
Member

What issue type does this pull request address? (keep at least one, remove the others)
/kind feature

What is this pull request for? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #402

Does this pull request has user-facing changes? (e.g. config changes, new/modified commands, new/modified flags)
Yes, new parameter to set the Redurect URL after the OAuth 2.0 authentication

Does this pull request add new dependencies?
No

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #404 (7635aee) into main (dee3165) will decrease coverage by 0.07%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
- Coverage   65.32%   65.25%   -0.07%     
==========================================
  Files          22       22              
  Lines         946      947       +1     
==========================================
  Hits          618      618              
- Misses        304      305       +1     
  Partials       24       24              
Files Coverage Δ
internal/app/oauth.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pacoorozco pacoorozco merged commit f93d7c4 into main Nov 1, 2023
6 of 8 checks passed
@pacoorozco pacoorozco deleted the issue-402 branch November 1, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow custom RedirectURLHostname
1 participant