Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to the auth command to set the local port #392

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Conversation

pacoorozco
Copy link
Member

Signed-off-by: pacoorozco [email protected]

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

What is this pull request for? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #370

Does this pull request has user-facing changes? (e.g. config changes, new/modified commands, new/modified flags)
Yes, a new flag available in the auth command to set the local port to bind the authentication server.

Does this pull request add new dependencies?
No

What else do we need to know?

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #392 (c359ca2) into main (fc634f1) will decrease coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   66.70%   66.62%   -0.08%     
==========================================
  Files          22       22              
  Lines         880      881       +1     
==========================================
  Hits          587      587              
- Misses        270      271       +1     
  Partials       23       23              
Files Coverage Δ
internal/app/oauth.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pacoorozco pacoorozco merged commit 7cef355 into main Oct 21, 2023
5 of 7 checks passed
@pacoorozco pacoorozco deleted the issue-370 branch October 21, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to specify web port for authentication
1 participant