audio sample entries ver1. improved hdlr. #77
Conversation
|
Thanks for this PR. Some of the commits are clear bug fixes (losing version field in tfdt and DataStream empty buffer). Some of your commits implement the QuickTime File Format not the ISO Base Media File Format. That's not a problem for the TKHD_FLAG_IN_POSTER flag because there is no conflict. For the hdlr box, that's problematic as it changes the names of the fields and this box is used in contexts not used in QTFF (e.g. in the meta box). I'd rather keep the name handler instead of componentSubtype. I'm curious about your comment saying that componentType is required in Firefox MSE. Firefox should support both. Have you filed a bug with them? Regarding the AudioSampleEntryV1, names are changed for reserved fields but with the same 0 value That's good. I'm curious about the new 4 fields (samplesPerPacket, bytesPerPacket, bytesPerFrame and bytesPerSample), they don't seem compatible with the ISOBMFF syntax as in v1 one should expect a SamplingRate box. I have to check further. Do you have files that use that? Can you post them somewhere? |
# Conflicts: # src/parsing/hdlr.js # src/parsing/sampleentry.js
added support for audio sample entries ver1. improved hdlr. made some minor fixes.