Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove testable mangled names #303

Merged
merged 1 commit into from
Dec 22, 2024
Merged

refactor: remove testable mangled names #303

merged 1 commit into from
Dec 22, 2024

Conversation

gouline
Copy link
Owner

@gouline gouline commented Dec 22, 2024

  • only internal logic extracted to decrease cyclomatic complexity, not intended to be testable separately, should have mangled names (__ prefixed), to prevent clashing names between mixins
  • private but separately testable logic should be _ prefixed and sanely named
  • not prefixed public names should be maintained and refactors count as breaking changes

@gouline gouline force-pushed the refactor/remove-testable-mangled-names branch from e26eb7e to 329248c Compare December 22, 2024 02:08
@gouline gouline force-pushed the refactor/remove-testable-mangled-names branch from 329248c to c542a42 Compare December 22, 2024 02:13
@gouline gouline merged commit c37cf49 into master Dec 22, 2024
1 check passed
@gouline gouline deleted the refactor/remove-testable-mangled-names branch December 22, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gouline