Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure models for better readability #206

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Restructure models for better readability #206

merged 1 commit into from
Jan 11, 2024

Conversation

gouline
Copy link
Owner

@gouline gouline commented Jan 9, 2024 •
edited
Loading

  • Rename MetabaseClient to DbtMetabase core
  • Separate models and exposures command logic into separate mixins
  • Make unit tests consistent with extracted mocks
  • Format JSON fixtures to make them readable
  • Unify defaults between CLI and programmatic API

@gouline gouline force-pushed the refactor-modules branch 8 times, most recently from 504f553 to adec42f Compare January 11, 2024 02:03
@gouline gouline merged commit 31cc607 into master Jan 11, 2024
1 check passed
@gouline gouline deleted the refactor-modules branch January 11, 2024 03:36
@gouline gouline mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gouline