fix(core): preserve the zoom status only when needed #974
Conversation
sehilyi
changed the title
src/compiler/spec-preprocess.ts
Outdated
| const lockUid = locksByViewUid[viewUid]; | ||
| const linkedViewUid = Object.entries(locksByViewUid).find(([_, uid]) => _ && uid === lockUid)?.[0]; | ||
| // Only if the linked view existed in the previous spec, we copy the zooming status | ||
| const linkedViewExistedPrev = !!prevSpec.views.find(v => v.uid === linkedViewUid); |
There was a problem hiding this comment.
The main code I added to fix the issue. This basically checks whether if this view is linked with a view that existed previously.
src/core/gosling-component.tsx
Outdated
| @@ -13,6 +13,7 @@ import { isEqual } from 'lodash-es'; | |||
| import * as uuid from 'uuid'; | |||
| import { publish } from '../api/pubsub'; | |||
| import type { IdTable } from '../api/track-and-view-ids'; | |||
| import { preverseZoomStatus } from '../compiler/spec-preprocess'; | |||
There was a problem hiding this comment.
Moved under \compiler – a better place than this?
There was a problem hiding this comment.
Given that this function is only used in gosling-component.tsx I think it should be kept in /core? I see you logic though, that it is making manipulations on the spec.
There was a problem hiding this comment.
Agreed. Would be better to put a file closer to where it is used! Added a util file for this function.
src/core/gosling-component.tsx
Outdated
| @@ -13,6 +13,7 @@ import { isEqual } from 'lodash-es'; | |||
| import * as uuid from 'uuid'; | |||
| import { publish } from '../api/pubsub'; | |||
| import type { IdTable } from '../api/track-and-view-ids'; | |||
| import { preverseZoomStatus } from '../compiler/spec-preprocess'; | |||
There was a problem hiding this comment.
Given that this function is only used in gosling-component.tsx I think it should be kept in /core? I see you logic though, that it is making manipulations on the spec.
Fix #973
Change List
Checklist