Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): first track ID should not be lost after compile #972

Merged
merged 3 commits into from
Sep 25, 2023
Merged

fix(core): first track ID should not be lost after compile #972

merged 3 commits into from
Sep 25, 2023

Conversation

sehilyi
Copy link
Member

@sehilyi sehilyi commented Sep 25, 2023 •
edited
Loading

Change List

  • Fix an issue that the ID of a first track in an overlaid view is lost after compiling (more specifically, after spreadTracksByData). I added a test to ensure that we do not have this issue again.

Example

gosRef.current.api.getTracks();

Screenshot 2023-09-25 at 17 15 30

cc @ThHarbig

Checklist

  • Ensure the PR works with all demos on the online editor
  • Unit tests added or updated
  • Examples added or updated
  • Documentation updated (e.g., added API functions)
  • Screenshots for visual changes (e.g., new encoding support or UI change on Editor)

@sehilyi sehilyi changed the title fix: first track ID should not be lost after compile fix(compile): first track ID should not be lost after compile Sep 25, 2023
@sehilyi sehilyi requested a review from ThHarbig September 25, 2023 21:17
@sehilyi sehilyi changed the title fix(compile): first track ID should not be lost after compile fix(compiler): first track ID should not be lost after compile Sep 25, 2023
@sehilyi sehilyi changed the title fix(compiler): first track ID should not be lost after compile fix(core): first track ID should not be lost after compile Sep 25, 2023
@sehilyi sehilyi merged commit f73410d into master Sep 25, 2023
6 of 11 checks passed
@sehilyi sehilyi deleted the sehilyi/fix-track-id branch September 25, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThHarbig ThHarbig Awaiting requested review from ThHarbig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sehilyi