Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support vertical tracks #451

Merged
merged 12 commits into from
Aug 10, 2021
Merged

feat: support vertical tracks #451

merged 12 commits into from
Aug 10, 2021

Conversation

sehilyi
Copy link
Member

@sehilyi sehilyi commented Aug 4, 2021

Updates

  • Add a gosling track named gosling-2d-track to use a 2d orientation.
  • Vertical tracks should work now properly
    • You can link between vertical tracks
    • Vertical stacking in a horizontal orientation changes to horizontal juxtaposition in vertical orientation.
    • top and bottom axes change to left and right axes in vertical orientation
    • xOffset and yOffset for positioning tracks

To-Do

Most Important

  • Allow track offsets (e.g., handle in circular layouts, multiple views with different arrangements) -- Add tests
  • vertical tracks in a single view should be stacked horizontally (juxtaposed)
  • show axis in a vertical track
  • convert "top" and "bottom" axes to "left" and "right" when it is a "vertical" orientation

Less Important For Now

  • Allow 2D crosshair
  • Flip texts in vertical tracks
  • allow flipping the y axis in a vertical track (can be done by positioning the track on the right of a view)
  • Handle the case when only the y-axis is genomic
  • Consider both axes properly for filtering tilesets
  • Allow grids for genomic axes
  • Snapping the position and size of tracks with another (if linkingId is shared) without needing to use xOffset and yOffset
  • x-position of a track does not seem to be precise, which looks to be related to react-grid-layout

Open Issues (for me to remember)

  • Do we need to switch width and height in vertical tracks? Without this, changing orientation requires changing width and height as well. We could also rename them.

Screenshots

Screen Shot 2021-08-09 at 7 42 03 PM

Aug-09-2021 15-40-34

Other Examples

Screen Shot 2021-08-05 at 2 48 56 PM

Screen Shot 2021-08-06 at 6 02 00 PM

Screen Shot 2021-08-06 at 7 13 27 PM

based on 4df2b2e...5948f06
Fixes #54
Towards #160

@sehilyi sehilyi mentioned this pull request Aug 4, 2021
@sehilyi sehilyi changed the title feat: 2d tracks feat: vertical tracks Aug 9, 2021
@sehilyi sehilyi changed the title feat: vertical tracks feat: support vertical tracks Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support vertical tracks
1 participant