Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): remove "template" key from template track after processing #1079

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix(core): remove "template" key from template track after processing #1079

merged 1 commit into from
Jun 12, 2024

Conversation

sehilyi
Copy link
Member

@sehilyi sehilyi commented Jun 12, 2024 •
edited
Loading

Fix #
Toward #

This is a PR into etowahadams/datatrack.

Change List

  • remove "template" key from template track after processing
    • This PR was necessary since a non-template track (i.e., a track converted from a template track) is incorrectly considered as a template track in Gosling.
      • Gosling considers a track TemplateTrack if there is a "template" key (code).
    • This addressed broken demo examples with template tracks in feat(core): remove DataTrack from schema and compiler #1074

Checklist

  • Ensure the PR works with all demos on the online editor
  • Unit tests added or updated
  • Examples added or updated
  • Documentation updated (e.g., added API functions)
  • Screenshots for visual changes (e.g., new encoding support or UI change on Editor)

@sehilyi sehilyi changed the base branch from main to etowahadams/datatrack June 12, 2024 19:18
@sehilyi sehilyi requested a review from etowahadams June 12, 2024 19:19
@sehilyi sehilyi mentioned this pull request Jun 12, 2024
Merged
5 tasks
@etowahadams etowahadams merged commit 0e17a44 into etowahadams/datatrack Jun 12, 2024
10 checks passed
@etowahadams etowahadams deleted the sehilyi/fix-template-track-check branch June 12, 2024 21:09
etowahadams added a commit that referenced this pull request Jun 12, 2024
@etowahadams @sehilyi
feat(core): remove DataTrack from schema and compiler (#1074)
2440948 
* feat: remove DataTrack from schema

* feat: remove data track from compiler

* feat: update schema

* feat: remove overrideTemplate

* feat: remove tests

* fix(core): remove `"template"` key from template track after processing (#1079)

fix(core): remove 'template' key from a trample track after spec processing

---------

Co-authored-by: SEHI L'YI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etowahadams etowahadams Awaiting requested review from etowahadams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sehilyi @etowahadams