Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): change _processedSpec to experimental_processedSpec #1077

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

etowahadams
Copy link
Contributor

Fix #1068
Toward #

Change List

  • Change _processedSpec in compile callback function to experimental_processedSpec

Checklist

  • Ensure the PR works with all demos on the online editor
  • Unit tests added or updated
  • Examples added or updated
  • Documentation updated (e.g., added API functions)
  • Screenshots for visual changes (e.g., new encoding support or UI change on Editor)

@etowahadams
Copy link
Contributor Author

In our discussion last week it seems like we settled on a new naming convention:

  • For internally used names: Use underscores (for example_header),
  • For externally used names: prefix with experimental, or wrap with experimental

Following this convention, I renamed _specProcessed to experimental_specProcessed. This is meant to be used externally, but it is unstable

@etowahadams etowahadams requested a review from sehilyi June 10, 2024 16:37
@sehilyi
Copy link
Member

sehilyi commented Jun 12, 2024

cc'ing @thomcsmits for heads up

@etowahadams etowahadams merged commit fc1441a into main Jun 12, 2024
4 checks passed
@etowahadams etowahadams deleted the etowahadams/unstable-specProcessed branch June 12, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit the callback function of compiled for naming/appropriateness
2 participants