Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core): add Playwright component testing #1037

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

etowahadams
Copy link
Contributor

@etowahadams etowahadams commented Jan 24, 2024

Fix #
Toward #

Change List

Checklist

  • Ensure the PR works with all demos on the online editor
  • Unit tests added or updated
  • Examples added or updated
  • Documentation updated (e.g., added API functions)
  • Screenshots for visual changes (e.g., new encoding support or UI change on Editor)

@etowahadams etowahadams changed the title feat: playwright ct test(core): add playwright ct Jan 29, 2024
@etowahadams etowahadams changed the title test(core): add playwright ct test(core): add playwright component testing Jan 29, 2024
@etowahadams etowahadams changed the title test(core): add playwright component testing test(core): add Playwright component testing Jan 29, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this got reordered when I added the new package.

ctPort: 3100,
ctViteConfig: {
/* Vite config to use for the component server. */
configFile: './vite.config.js',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the existing Vite config file when doing the playwright tests

@etowahadams
Copy link
Contributor Author

Playwright component tests are more maintainable than the previous strategy of running the full editor and copy pasting different specs.

@etowahadams etowahadams marked this pull request as ready for review January 29, 2024 23:20
@etowahadams etowahadams merged commit 9ecd4d3 into main Jan 29, 2024
7 checks passed
@etowahadams etowahadams deleted the etowahadams/persist-gosling-track-model branch January 29, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant