Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(editor): add a demo for comparing rendering approaches #1023

Merged
merged 2 commits into from
Jan 3, 2024
Merged

chore(editor): add a demo for comparing rendering approaches #1023

merged 2 commits into from
Jan 3, 2024

Conversation

sehilyi
Copy link
Member

@sehilyi sehilyi commented Dec 22, 2023 •
edited
Loading

Fix #
Toward #

Change List

  • Added an example with two alignment tracks with and without new experimental rendering approach

Screenshot 2023-12-22 at 11 55 15 AM

Screenshot 2023-12-23 at 12 51 56 PM

Checklist

  • Ensure the PR works with all demos on the online editor
  • Unit tests added or updated
  • Examples added or updated
  • Documentation updated (e.g., added API functions)
  • Screenshots for visual changes (e.g., new encoding support or UI change on Editor)

@sehilyi sehilyi changed the base branch from main to etowahadams/stretch-tile December 22, 2023 16:56
@sehilyi sehilyi changed the title core(editor): add a demo for comparing rendering approaches chore(editor): add a demo for comparing rendering approaches Dec 22, 2023
@etowahadams
Copy link
Contributor

Good idea to add this example! Thanks

@sehilyi sehilyi mentioned this pull request Dec 23, 2023
Merged
5 tasks
@etowahadams etowahadams merged commit cf3fdd9 into etowahadams/stretch-tile Jan 3, 2024
4 checks passed
@etowahadams etowahadams deleted the sehilyi/stretch-tile-demo branch January 3, 2024 20:28
etowahadams added a commit that referenced this pull request Jan 8, 2024
@etowahadams @sehilyi
perf(core): stretch certain marks instead of redraw (#1018)
0b405ba 
* feat: stretchable marks

* feat: stretchGraphics option

* feat: stretchGraphicsThreshold

Co-authored-by: Sehi L'Yi <[email protected]>

* feat: add stretchGraphicsThreshold to schema

* fix: check all resolved tracks stretchable

* chore: make first render more clear

* chore(editor): add a demo for comparing rendering approaches (#1023)

* chore: add a demo for perf comparison

* chore: add a demo thumbnail

---------

Co-authored-by: sehilyi <[email protected]>

* fix: make alignment example wider

* chore: linting

* chore: cleanup

* fix: update schema

* feat: add title

* fix: no stretching when mouse interactions

---------

Co-authored-by: Sehi L'Yi <[email protected]>
Co-authored-by: sehilyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sehilyi @etowahadams