chore(core): pnpm #1007
Merged
chore(core): pnpm #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etowahadams
commented
Dec 8, 2023
| @@ -64,6 +65,7 @@ | |||
| "d3-array": "^2.5.1", | |||
| "d3-color": "^2.0.0", | |||
| "d3-dsv": "^2.0.0", | |||
| "d3-format": "^3.1.0", | |||
There was a problem hiding this comment.
Because pnpm doesn't hoist package dependencies in node_modules, I needed to add several packages.
etowahadams
commented
Dec 8, 2023
| @@ -132,6 +141,7 @@ | |||
| "react-resize-detector": "^4.2.3", | |||
| "react-router-dom": "^5.2.0", | |||
| "remark-gfm": "^1.0.0", | |||
| "safe-stable-stringify": "^2.4.3", | |||
There was a problem hiding this comment.
Used when running pnpm schema
sehilyi
reviewed
Dec 9, 2023
|
|
||
| ```sh | ||
| git clone https://github.com/gosling-lang/gosling.js.git # Clone the repository to your current directory | ||
| cd gosling.js # Navigate to gosling repository | ||
| yarn # Install dependencies | ||
| yarn start # Start a local server running the Gosling online editor | ||
| pnpm # Install dependencies |
There was a problem hiding this comment.
It looks like pnpm itself does not install packages?
Suggested change
| pnpm # Install dependencies | |
| pnpm install # Install dependencies |
There was a problem hiding this comment.
I just noticed this, too. Seems like it slipped through the cracks and wasn't fixed in the PR?
There was a problem hiding this comment.
Good catch, will make the PR now!
sehilyi
approved these changes
Dec 9, 2023
|
Great thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #
Toward #897
Change List
yarnwithpnpmas the main package manager.We use pnpm workspaces in Guisling and other projects in the lab for monorepo package management. To be consistent, Gosling should also use pnpm. This is in preparation for making Gosling a monorepo.
Checklist