Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate triggering tests on automated PR #9

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

rkeur7
Copy link
Contributor

@rkeur7 rkeur7 commented Nov 18, 2024

@rkeur7 rkeur7 requested a review from a team as a code owner November 18, 2024 15:19
mario-shippo
mario-shippo previously approved these changes Nov 18, 2024
Copy link

@mario-shippo mario-shippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isnt required to pump the php version here?

"php": "^8.1",

Other than that, LGTM

Copy link

@mario-shippo mario-shippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@rkeur7 rkeur7 merged commit d31f4b9 into main Nov 18, 2024
1 check passed
@rkeur7 rkeur7 deleted the CET-350-investigate-triggering-tests-on-automated-pr branch November 18, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants