Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files should be compared with hash rather than filename #140

Open
magneticflux- opened this issue Jun 13, 2022 · 6 comments
Open

Files should be compared with hash rather than filename #140

magneticflux- opened this issue Jun 13, 2022 · 6 comments
Labels
bug Something doesn't work as expected

Comments

@magneticflux-
Copy link

Description

When editing a file (without renaming) in the mods/user folder and running ferium upgrade does not copy the file to the mods folder.

To Reproduce

  1. Create a new file in the user folder
  2. Run ferium upgrade and see the copied file
  3. Edit the original file
  4. Run ferium upgrade and see the file is not updated with the new contents

Software version

  • OS (macOS/Windows/Linux)
    • Windows
  • Ferium Version (output of ferium -V)
    • 4.1.4

Additional information

I ran shasum on the files to make sure I wasn't going crazy when my mods weren't updating after rebuilding them and fixing bugs 😆:

shasum effective-1.2.2.jar user/effective-1.2.2.jar
246876f59cd9f18f74e5a93def235da2a6b6243d  effective-1.2.2.jar
fc2452eaa7f4f507e46960ea99086afe4ffe93f7  user/effective-1.2.2.jar
@magneticflux- magneticflux- added the bug Something doesn't work as expected label Jun 13, 2022
@theRookieCoder theRookieCoder changed the title Editing files in the user folder does not update the file in the mods folder Files should be compared with hash rather than filename Jun 14, 2022
@theRookieCoder
Copy link
Collaborator

Also if they are compared using hashes rather than filenames, the current filename (before upgrading) should be retained, or that could be configurable too. (from #252)

@ok-coder1
Copy link

Did your CurseForge Idea become implemented? I don't see anything telling if it's implemented.
https://curseforge-ideas.overwolf.com/ideas/CF-I-2686

@theRookieCoder
Copy link
Collaborator

The feature already exists, CurseForge calls it fingerprints and it's what's used when scanning.

@ok-coder1
Copy link

ok-coder1 commented Oct 19, 2024

That means this is implemented, right? (in ferium)

@theRookieCoder
Copy link
Collaborator

No it is only used in scanning, I haven't implemented it anywhere else.

@ok-coder1
Copy link

ok-coder1 commented Oct 19, 2024

You could implement it here(#140) and to disable mods(#219) which would close both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn't work as expected
Development

No branches or pull requests

3 participants