Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlink mods to output directories from a common mod storage #109

Open
JustSimplyKyle opened this issue Jun 3, 2022 · 6 comments
Open
Labels
enhancement Improvements to the project

Comments

@JustSimplyKyle
Copy link
Contributor

JustSimplyKyle commented Jun 3, 2022

Profile 1 (quilt, 1.18.2):

  • iris(from modrinth)
  • sodium(from modrinth)
  • enhanced block entities

Profile 2 (fabric, 1.18.2):

  • iris(from modrinth)
  • sodium(from modrinth)
  • c2me

I hope that if the two profiles have identical mods, ferium will automatically symlink them from the same file.
Even if the modloader profile settings are not the same, if the mod is the same they should be symlinked.

@theRookieCoder theRookieCoder added the enhancement Improvements to the project label Jun 3, 2022
@theRookieCoder
Copy link
Collaborator

theRookieCoder commented Jun 3, 2022

I really like this idea! It's basically how pnpm works actually.

@theRookieCoder theRookieCoder changed the title Symlinking mods accross different profiles Symlink mods to profiles from a common mod storage Jun 3, 2022
@JustSimplyKyle
Copy link
Contributor Author

JustSimplyKyle commented Jun 3, 2022

I got the idea from xmcl(x-minecraft-laucher)!

@theRookieCoder theRookieCoder changed the title Symlink mods to profiles from a common mod storage Symlink mods to output directories from a common mod storage Jun 3, 2022
@noahdotpy
Copy link

You could probably have a hash in the mod's file name that is generated from the version of the mod, modloader, minecraft version and the ID or something like this.
Now whenever ferium is downloading a mod you could check if there is already a file with the same hash and simply symlink.
I feel like this could also save on disk storage space.

This is an awesome idea!

@theRookieCoder
Copy link
Collaborator

theRookieCoder commented Oct 9, 2022

Firstly this directly conflicts with #140, and it also provides no benefit over using the hash of the files' contents.

@noahdotpy
Copy link

If you regularly switch profiles then the mods could be stored in this store instead of constantly re-downloading possibly 100s of megabytes of mod files each and every time you want to switch profiles.

@theRookieCoder
Copy link
Collaborator

You could probably have a hash in the mod's file name that is generated from the version of the mod, modloader, minecraft version and the ID or something like this.

I was referring to this in my comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to the project
Development

No branches or pull requests

3 participants