Fix open-metadata#13982: Fix userFQN encoding while creating mentions (…

…open-metadata#14496) * Fix open-metadata#13982: Fix userFQN encoding while creating mentions * quote only teams or users
gorgias · Dec 26, 2023 · 4b7f4f4 · 4b7f4f4
1 parent e98ae8a
commit 4b7f4f4
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/bootstrap/sql/migrations/native/1.2.4/mysql/schemaChanges.sql b/bootstrap/sql/migrations/native/1.2.4/mysql/schemaChanges.sql
@@ -0,0 +1,3 @@
+update field_relationship fr INNER JOIN  user_entity ue on fr.fromFQN=ue.name
+    set fr.fromFQNHASH=MD5(JSON_UNQUOTE(JSON_EXTRACT(ue.json, '$.fullyQualifiedName'))),
+    fr.fromFQN=JSON_UNQUOTE(JSON_EXTRACT(ue.json, '$.fullyQualifiedName'))  where fr.fromType='user';
diff --git a/bootstrap/sql/migrations/native/1.2.4/postgres/schemaChanges.sql b/bootstrap/sql/migrations/native/1.2.4/postgres/schemaChanges.sql
@@ -0,0 +1,3 @@
+update field_relationship fr
+    set fromFQNHASH=MD5(ue.json->>'fullyQualifiedName'),
+        fromFQN=ue.json->>'fullyQualifiedName' from user_entity ue where fr.fromType='user' and fr.fromFQN=ue.name;
diff --git a/...etadata-service/src/main/java/org/openmetadata/service/resources/feeds/MessageParser.java b/...etadata-service/src/main/java/org/openmetadata/service/resources/feeds/MessageParser.java
@@ -23,6 +23,8 @@
 import lombok.Getter;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.commons.lang3.StringUtils;
+import org.openmetadata.service.Entity;
+import org.openmetadata.service.util.FullyQualifiedName;
 
 @Slf4j
 public final class MessageParser {
@@ -167,18 +169,19 @@ public static EntityLink parse(String link) {
       EntityLink entityLink = null;
       while (matcher.find()) {
         if (entityLink == null) {
+          String entityType = matcher.group(1);
           String entityFQN = matcher.group(2);
           if (entityFQN == null) {
             throw new IllegalArgumentException(
                 "Invalid Entity Link. Entity FQN is missing in " + link);
           }
+          if (entityType.equalsIgnoreCase(Entity.USER)
+              || entityType.equalsIgnoreCase(Entity.TEAM)) {
+            entityFQN = FullyQualifiedName.quoteName(entityFQN);
+          }
           entityLink =
               new EntityLink(
-                  matcher.group(1),
-                  entityFQN,
-                  matcher.group(4),
-                  matcher.group(6),
-                  matcher.group(8));
+                  entityType, entityFQN, matcher.group(4), matcher.group(6), matcher.group(8));
         } else {
           throw new IllegalArgumentException("Unexpected multiple entity links in " + link);
         }