Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move beep.Silence to generators.Silence #131

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Move beep.Silence to generators.Silence #131

merged 2 commits into from
Nov 9, 2023

Conversation

MarkKremer
Copy link
Contributor

  • Moved the Silence function to the generators subpackage. The old function is kept intact but with a deprecation notice. Can be removed when we want to move to a new major version.
  • Tested and optimized the function while I'm at it.

@MarkKremer MarkKremer marked this pull request as ready for review November 5, 2023 11:58
@MarkKremer MarkKremer requested a review from a team November 5, 2023 11:58
@MarkKremer MarkKremer merged commit 12f8f93 into main Nov 9, 2023
1 check passed
@MarkKremer MarkKremer deleted the move-silence-func-to-generators branch November 9, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duysqubix duysqubix duysqubix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkKremer @duysqubix