Add explanatory comment to mp3 decoder test

gopxl · Nov 4, 2023 · 95ab036 · 95ab036
1 parent 84dd3d8
commit 95ab036
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.../testdata/valid_44100hz_22050_samples.mp3 → ...stdata/valid_44100hz_x_padded_samples.mp3 b/.../testdata/valid_44100hz_22050_samples.mp3 → ...stdata/valid_44100hz_x_padded_samples.mp3
diff --git a/mp3/decode_test.go b/mp3/decode_test.go
@@ -11,13 +11,15 @@ import (
 )
 
 func TestDecoder_ReturnBehaviour(t *testing.T) {
-	f, err := os.Open(testtools.TestFilePath("valid_44100hz_22050_samples.mp3"))
+	f, err := os.Open(testtools.TestFilePath("valid_44100hz_x_padded_samples.mp3"))
 	assert.NoError(t, err)
 	defer f.Close()
 
 	s, _, err := mp3.Decode(f)
 	assert.NoError(t, err)
-	//assert.Equal(t, 22050, s.Len()) // todo: mp3 seems to return more samples than there are in the file. Uncomment this when fixed.
+	// The length of the streamer isn't tested because mp3 files have
+	// a different padding depending on the decoder used.
+	// https://superuser.com/a/1393775
 
 	testtools.AssertStreamerHasCorrectReturnBehaviour(t, s, s.Len())
 }