Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 342 Blocking & non-blocking APIs uniformity #345

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix issue 342 Blocking & non-blocking APIs uniformity #345

wants to merge 2 commits into from
+76 −42

Conversation

qlli
Copy link
Contributor

@qlli qlli commented Oct 11, 2024 •
edited
Loading

  1. Add non-blocking API such as StartPlay, StartAnimate
  2. Add blocking API: BroadcastAndWait

issue342.zip

@nighca nighca linked an issue Oct 11, 2024 that may be closed by this pull request
Blocking & non-blocking APIs uniformity #342
Open
nighca
nighca approved these changes Oct 12, 2024
View reviewed changes
game.go
}

func (p *Game) Play__1(media Sound, wait bool) {
p.Play__2(media, &PlayOptions{Wait: wait})
func (p *Game) Play__1(soundName string, options *PlayOptions) {
Copy link
Collaborator

@nighca nighca Oct 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to restore the original order of overloads after the overload issue fixed by gop. Related PR: goplus/gop#1991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nighca nighca nighca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blocking & non-blocking APIs uniformity
2 participants
@qlli @nighca