Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update region-flags from upstream. #386

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SaveTheRbtz
Copy link
Contributor

@SaveTheRbtz SaveTheRbtz commented Apr 1, 2022

This updates upstream to 1.2.1 release. It contains quite a bit of changes:

It encompassed quite a bit of upstream changes:
* All png flags now have width of 1024px.  This should improve emoji quality for the most flags.
* Many flags have improved color schemes. Most notably: CN, HK, MR, NO, TH.
* Added AU, CO, DE, ES regions.
* Added flags for:
  * CQ (island of Sark) https://www.iso.org/obp/ui/#iso:code:3166:CQ
  * EZ (alias for EU) https://www.iso.org/obp/ui/#iso:code:3166:EZ
  * FX (Metropolitan France) https://www.iso.org/obp/ui/#iso:code:3166:FX
  * SU (Soviet Union) https://www.iso.org/obp/ui/#iso:code:3166:SU
  * UK (alias for GB) https://www.iso.org/obp/ui/#iso:code:3166:UK
* Fixed flags for:
  * BL
  * BQ
  * MQ
  * RE
  * US-MS (Mississippi)
  * US-RI (Rhode Island)
@SaveTheRbtz SaveTheRbtz force-pushed the update-region-flags branch from d413a58 to 3f9e31f Compare April 4, 2022 01:52
@SaveTheRbtz SaveTheRbtz mentioned this pull request Apr 4, 2022
@dscorbett
Copy link

The new flags for BL, BQ, MQ, and RE, though the official flags, are duplicates of other flags and do not match the flags used by most other fonts. It wouldn’t be incorrect to change the flags, but it might be undesirable.

CQ and UK are not valid region codes in CLDR, so they should not be used for emoji flags.

@SaveTheRbtz
Copy link
Contributor Author

SaveTheRbtz commented Apr 7, 2022

For the changed flags seems like these aliases all have a dedicated subregions e.g.: FR-BL, NL-BQ, FR-MQ, FR-RE. Maybe if custom flag is desired it should be referenced as a subregion while region should use NL/FR flags? (I can add add FR and NL subdivisions to the upstream repo.)

As for UK and CQ, it should be fine since they are not yet a part of SELECTED_FLAGS:

noto-emoji/Makefile

Lines 56 to 82 in 2203a22

SELECTED_FLAGS = AC AD AE AF AG AI AL AM AO AQ AR AS AT AU AW AX AZ \
BA BB BD BE BF BG BH BI BJ BL BM BN BO BQ BR BS BT BW BY BZ \
CA CC CD CF CG CH CI CK CL CM CN CO CR CU CV CW CX CY CZ \
DE DJ DK DM DO DZ \
EC EE EG EH ER ES ET EU \
FI FJ FK FM FO FR \
GA GB GD GE GF GG GH GI GL GM GN GP GQ GR GS GT GU GW GY \
HK HN HR HT HU \
IC ID IE IL IM IN IO IQ IR IS IT \
JE JM JO JP \
KE KG KH KI KM KN KP KR KW KY KZ \
LA LB LC LI LK LR LS LT LU LV LY \
MA MC MD ME MG MH MK ML MM MN MO MP MQ MR MS MT MU MV MW MX MY MZ \
NA NC NE NF NG NI NL NO NP NR NU NZ \
OM \
PA PE PF PG PH PK PL PM PN PR PS PT PW PY \
QA \
RE RO RS RU RW \
SA SB SC SD SE SG SH SI SK SL SM SN SO SR SS ST SV SX SY SZ \
TA TC TD TF TG TH TJ TK TL TM TN TO TR TT TV TW TZ \
UA UG UN US UY UZ \
VA VC VE VG VI VN VU \
WF WS \
XK \
YE YT \
ZA ZM ZW \
GB-ENG GB-SCT GB-WLS

(Although, I would suppose, given that CQ has a 2 letter ISO code, it's just a matter of time before it is added to CLDR.)

PS. As for some flags being the same-- this is a side effect of one of the downstream build systems (IIRC npm) that had trouble with symlinks. Since they are byte-by-byte identical this should not have long-term negative effect on the git history size. As for the potential font size increase we can add these to either

# flag aliases
or
FLAG_ALIASES = {

@SaveTheRbtz
Copy link
Contributor Author

A friendly ping ^ =)

@mapmeld
Copy link

mapmeld commented Mar 6, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants