-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update region-flags from upstream. #386
base: main
Are you sure you want to change the base?
Conversation
It encompassed quite a bit of upstream changes: * All png flags now have width of 1024px. This should improve emoji quality for the most flags. * Many flags have improved color schemes. Most notably: CN, HK, MR, NO, TH. * Added AU, CO, DE, ES regions. * Added flags for: * CQ (island of Sark) https://www.iso.org/obp/ui/#iso:code:3166:CQ * EZ (alias for EU) https://www.iso.org/obp/ui/#iso:code:3166:EZ * FX (Metropolitan France) https://www.iso.org/obp/ui/#iso:code:3166:FX * SU (Soviet Union) https://www.iso.org/obp/ui/#iso:code:3166:SU * UK (alias for GB) https://www.iso.org/obp/ui/#iso:code:3166:UK * Fixed flags for: * BL * BQ * MQ * RE * US-MS (Mississippi) * US-RI (Rhode Island)
d413a58
to
3f9e31f
Compare
The new flags for BL, BQ, MQ, and RE, though the official flags, are duplicates of other flags and do not match the flags used by most other fonts. It wouldn’t be incorrect to change the flags, but it might be undesirable. CQ and UK are not valid region codes in CLDR, so they should not be used for emoji flags. |
For the changed flags seems like these aliases all have a dedicated subregions e.g.: FR-BL, NL-BQ, FR-MQ, FR-RE. Maybe if custom flag is desired it should be referenced as a subregion while region should use NL/FR flags? (I can add add FR and NL subdivisions to the upstream repo.) As for UK and CQ, it should be fine since they are not yet a part of Lines 56 to 82 in 2203a22
(Although, I would suppose, given that CQ has a 2 letter ISO code, it's just a matter of time before it is added to CLDR.) PS. As for some flags being the same-- this is a side effect of one of the downstream build systems (IIRC npm) that had trouble with symlinks. Since they are byte-by-byte identical this should not have long-term negative effect on the git history size. As for the potential font size increase we can add these to either Line 7 in 2203a22
noto-emoji/materialize_emoji_images.py Line 39 in 2203a22
|
A friendly ping ^ =) |
Note that Sark (CQ) has been added to CLDR regions https://github.com/unicode-org/cldr/blob/main/common/validity/region.xml / https://github.com/unicode-org/icu/pull/2338/files |
This updates upstream to 1.2.1 release. It contains quite a bit of changes: