Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[klippa] use serializer framework #1272

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[klippa] use serializer framework #1272

merged 1 commit into from
Dec 3, 2024
+375 −213

Conversation

qxliu76
Copy link
Contributor

@qxliu76 qxliu76 commented Dec 2, 2024

No description provided.

cmyr
cmyr approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable, a few things inline :)

klippa/src/glyf_loca.rs Show resolved Hide resolved
klippa/src/lib.rs Show resolved Hide resolved
klippa/src/name.rs Show resolved Hide resolved
klippa/src/serialize.rs Outdated Show resolved Hide resolved
@qxliu76 qxliu76 merged commit aea2fea into main Dec 3, 2024
10 checks passed
@qxliu76 qxliu76 deleted the use_serializer branch December 3, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garretrieger garretrieger garretrieger approved these changes

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qxliu76 @cmyr @garretrieger