Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

Change queue.handler to send null if the queue has no errors #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxrevilo
Copy link
Contributor

This will make Firebase Util compatible with AngularFire, if queue.handler sends undefined instead of null AngularFire won't trigger the callbacks.

I tried my best with the tests, and I had to change two tests in test/NormalizedCollection/Record.spec.js.

…as no errors

This will make Firebase Util compatible with AngularFire, if queue.handler sends undefined instead of null AngularFire won't trigger the callbacks.
@katowulf
Copy link
Contributor

if queue.handler sends undefined instead of null AngularFire won't trigger the callbacks.

Is this a bug in AF? Sounds like it probably is. Is there are error being thrown?

@katowulf
Copy link
Contributor

Thanks, btw. Looks like a great PR. It will take me a bit to run the tests and get it merged. Ping me if you don't see progress in a week.

@maxrevilo
Copy link
Contributor Author

Ok.

No there is no error being thrown. At the beginning I though that was an error in AF, but AF works perfect with firebase.js. AF expects the first parameter of the callbacks to be null if there is no errors, and thats what firebase.js does. For that reason I though that I should try to change Firebase Utils instead of AF.

@jaufgang jaufgang mentioned this pull request Nov 20, 2015
@jaufgang
Copy link

This issue fixes issue #56, which continues to vex me. Please merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants