-
Notifications
You must be signed in to change notification settings - Fork 272
Added a try except block at the end of the Upload() method, trying to… #144
base: master
Are you sure you want to change the base?
Added a try except block at the end of the Upload() method, trying to… #144
Conversation
… close the file. If it's not a file, discard the error.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it!
Il 13 set 2018 23:53, googlebot <[email protected]> ha scritto:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
…________________________________
What to do if you already signed the CLA
Individual signers
* It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
* Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot<http://go/cla#troubleshoot> (Public version<https://opensource.google.com/docs/cla/#troubleshoot>).
* The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>.
* The email used to register you as an authorized contributor must also be attached to your GitHub account<https://github.com/settings/emails>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#144 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABGdQF7i8uElpgfd1s63s9F7bi0XJoSTks5uatPzgaJpZM4WoRVq>.
|
CLAs look good, thanks! |
Sorry for the very long delay getting to this PR. It seems like this would cause a problem if you called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not move the open() call out of SetFileContent and into Upload, and remove the try-except?
… close the file. If it's not a file, discard the error.
Sorry if not 100% correct but I'm not familiar with pull requests.