Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): implement custom tracer_provider injection for opentelemetry traces #1229

Merged
merged 19 commits into from
Nov 15, 2024
Merged

feat(spanner): implement custom tracer_provider injection for opentelemetry traces #1229

merged 19 commits into from
Nov 15, 2024

Commits on Nov 14, 2024

  1. all: implement custom tracer_provider injection 

    An important feature for observability is to allow the injection
of a custom tracer_provider instead of always using the global
tracer_provider by sending in

    observability_options=dict(
        tracer_provider=tracer_provider,
        enable_extended_tracing=True,
    )
    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    da102c4 View commit details
    Browse the repository at this point in the history

  2. Address review feedback by attaching observability_options to Client … 

    …only
    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2181ca9 View commit details
    Browse the repository at this point in the history

  3. Attach observability_options directly before trace_call

    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    540d0b8 View commit details
    Browse the repository at this point in the history

  4. More reverts for formatting

    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0b9ca49 View commit details
    Browse the repository at this point in the history

  5. Plumb observability_options into _restart_on_unavailable

    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    854a3ff View commit details
    Browse the repository at this point in the history

  6. completely decouple observability_options from session

    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3e9a8ca View commit details
    Browse the repository at this point in the history

  7. apply SPANNER_ENABLE_EXTENDED_TRACING but in inverse due to compatibi… 

    …lity
    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8af9e75 View commit details
    Browse the repository at this point in the history

  8. Document SPANNER_ENABLE_EXTENDED_TRACING in environment

    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    7adab38 View commit details
    Browse the repository at this point in the history

  9. Revert a vestige of mock

    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    afd01e1 View commit details
    Browse the repository at this point in the history

  10. tests: add unit test for propagating TracerProvider

    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ca8d598 View commit details
    Browse the repository at this point in the history

  11. Add preliminary end-to-end test to check for injection of observabili… 

    …ty_options
    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6fb046c View commit details
    Browse the repository at this point in the history

  12. Document default enable_extended_tracing value

    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    fb3e8ea View commit details
    Browse the repository at this point in the history

  13. Carve out observability_options test

    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    762390c View commit details
    Browse the repository at this point in the history

  14. Ensure that observability_options test sets up and deletes database

    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    21bfbcd View commit details
    Browse the repository at this point in the history

  15. Ensure instance.create() is invoked in system tests

    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    797241f View commit details
    Browse the repository at this point in the history

  16. Use getattr for mock _Client

    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    25edeaa View commit details
    Browse the repository at this point in the history

  17. Update with code review suggestions

    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    42b9a4c View commit details
    Browse the repository at this point in the history

  18. Deal with mock.Mock false positives failing tests

    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6c8bb88 View commit details
    Browse the repository at this point in the history

  19. Address review feedback

    @odeke-em
    odeke-em committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    196e9a0 View commit details
    Browse the repository at this point in the history