Deal with mock.Mock false positives failing tests

googleapis · Nov 14, 2024 · 6c8bb88 · 6c8bb88
1 parent 42b9a4c
commit 6c8bb88
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/google/cloud/spanner_v1/_opentelemetry_tracing.py b/google/cloud/spanner_v1/_opentelemetry_tracing.py
@@ -68,7 +68,7 @@ def trace_call(name, session, extra_attributes=None, observability_options=None)
     # on by default.
     enable_extended_tracing = True
 
-    if observability_options:
+    if type(observability_options) == dict:  # Avoid false positives with mock.Mock
         tracer_provider = observability_options.get("tracer_provider", None)
         enable_extended_tracing = observability_options.get(
             "enable_extended_tracing", enable_extended_tracing