fix: speed up listDocuments pagination (#1344)

googleapis · Oct 26, 2020 · 498301d · 498301d
1 parent 6139b5f
commit 498301d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/dev/src/reference.ts b/dev/src/reference.ts
@@ -2429,9 +2429,10 @@ export class CollectionReference<T = firestore.DocumentData>
         parent: parentPath.formattedName,
         collectionId: this.id,
         showMissing: true,
-        // Setting `pageSize` to the maximum allowed value lets the backend cap
-        // the page size (currently to 300).
-        pageSize: Math.pow(2, 32) - 1,
+        // Setting `pageSize` to an arbitrarily large value lets the backend cap
+        // the page size (currently to 300). Note that the backend rejects
+        // MAX_INT32 (b/146883794).
+        pageSize: Math.pow(2, 16) - 1,
         mask: {fieldPaths: []},
       };
 

diff --git a/dev/test/collection.ts b/dev/test/collection.ts
@@ -155,7 +155,7 @@ describe('Collection interface', () => {
           parent: `${DATABASE_ROOT}/documents/a/b`,
           collectionId: 'c',
           showMissing: true,
-          pageSize: 4294967295,
+          pageSize: 65535,
           mask: {fieldPaths: []},
         });