Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add MySQLEngine and Loader load functionality #9

Merged
merged 13 commits into from
Jan 30, 2024
Merged

feat: add MySQLEngine and Loader load functionality #9

merged 13 commits into from
Jan 30, 2024

Conversation

jackwotherspoon
Copy link
Contributor

@jackwotherspoon jackwotherspoon commented Jan 25, 2024 •
edited
Loading

PR implements the following for MySQL:

  • Add the MySQLEngine class to be shared across the MySQLVectorStore, MySQLLoader and MySQLMemory
  • Add __init__ and load methods for MySQLLoader
  • Initial integration test setup

jackwotherspoon and others added 2 commits January 24, 2024 20:15
@jackwotherspoon
feat: add CloudSQLMySQLEngine class (#7)
9ff3839
@loeng2023
feat: support load document by query (#8)
eb2cba1 
* load documents by query.

* make integration test works

* rebase to include CloudSQLMySQLEngine

* fix in test

* minor change

* Update class naming

* refine typing

* fix lint
@jackwotherspoon jackwotherspoon self-assigned this Jan 25, 2024
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner January 25, 2024 22:56
kurtisvg
kurtisvg requested changes Jan 26, 2024
View reviewed changes
.github/workflows/lint.yml Outdated Show resolved Hide resolved
mypy.ini Outdated Show resolved Hide resolved
src/langchain_google_cloud_sql_mysql/mysql_engine.py Show resolved Hide resolved
src/langchain_google_cloud_sql_mysql/mysql_engine.py Show resolved Hide resolved
src/langchain_google_cloud_sql_mysql/mysql_engine.py Show resolved Hide resolved
src/langchain_google_cloud_sql_mysql/mysql_engine.py Outdated Show resolved Hide resolved
src/langchain_google_cloud_sql_mysql/mysql_engine.py Outdated Show resolved Hide resolved
src/langchain_google_cloud_sql_mysql/mysql_engine.py Outdated Show resolved Hide resolved
src/langchain_google_cloud_sql_mysql/mysql_loader.py Outdated Show resolved Hide resolved
@jackwotherspoon
Copy link
Contributor Author

Need to update tests

@jackwotherspoon
Copy link
Contributor Author

Need to update tests

Tests are back to green

@jackwotherspoon
Copy link
Contributor Author

@kurtisvg Should be ready for another look. As discussed offline there is not a huge difference between the class attribute connector and module level connector. We can easily update it in the future as needed.

@jackwotherspoon jackwotherspoon merged commit 6c8af85 into main Jan 30, 2024
8 checks passed
@jackwotherspoon jackwotherspoon deleted the staging branch January 30, 2024 19:43
@release-please release-please bot mentioned this pull request Jan 30, 2024
Merged
@jackwotherspoon jackwotherspoon restored the staging branch January 30, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loeng2023 loeng2023 loeng2023 left review comments

@kurtisvg kurtisvg kurtisvg approved these changes

@averikitsch averikitsch Awaiting requested review from averikitsch

Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackwotherspoon @averikitsch @kurtisvg @loeng2023