feat: add MySQLChatMessageHistory class
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* load documents by query. * make integration test works * rebase to include CloudSQLMySQLEngine * fix in test * minor change * Update class naming * refine typing * fix lint
Co-authored-by: Kurtis Van Gent <[email protected]>
…metadata columns in doc laoder.
averikitsch
reviewed
Feb 1, 2024
src/langchain_google_cloud_sql_mysql/mysql_chat_message_history.py
Outdated
Show resolved
Hide resolved
src/langchain_google_cloud_sql_mysql/mysql_chat_message_history.py
Outdated
Show resolved
Hide resolved
|
|
||
| @pytest.fixture(name="memory_engine") | ||
| def setup() -> Generator: | ||
| engine = MySQLEngine.from_instance( |
There was a problem hiding this comment.
Documentation should have notes on how to set up authentication
There was a problem hiding this comment.
do you mean "documentation" as in a docstring explaining setup or are you talking about wider documentation around how to run integrations tests and the setup pre-reqs? Will be adding a testing section to CONTRIBUTING.md in a future PR
jackwotherspoon
commented
Feb 1, 2024
src/langchain_google_cloud_sql_mysql/mysql_chat_message_history.py
Outdated
Show resolved
Hide resolved
averikitsch
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
MySQLChatMessageHistoryclass which allows functionality of a memory store.Follows pattern of other chat message history integrations: https://github.com/langchain-ai/langchain/tree/master/libs/community/langchain_community/chat_message_histories