feat: add MySQLChatMessageHistory class #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwotherspoon
commented
Jan 26, 2024
Comment on lines
+55
to
+57
| # load SQLAlchemy row objects into dicts | ||
| items = [json.loads(result[0]) for result in results] | ||
| messages = messages_from_dict(items) |
There was a problem hiding this comment.
@totoleon I updated this code from the POC to use messages_from_dict instead of message_chunk_to_message.
It now returns the proper HumanMessage and AIMessage message objects as the other current integrations do. Let me know what you think 😄
There was a problem hiding this comment.
Did you test it? It was messages_from_dict copied from the pg PoC code, but it didn't work for some reason, and got fixed after I changed to message_chunk_to_message.
I didn't dive deep though. It should be fine if you were able to make it work.
There was a problem hiding this comment.
Yup the integration test works wonders, the trick was json.loads to turn the string into a dict.
totoleon
approved these changes
Jan 26, 2024
src/langchain_google_cloud_sql_mysql/mysql_chat_message_history.py
Outdated
Show resolved
Hide resolved
src/langchain_google_cloud_sql_mysql/mysql_chat_message_history.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
MySQLChatMessageHistoryclass which allows functionality of a memory store.Follows pattern of other chat message history integrations: https://github.com/langchain-ai/langchain/tree/master/libs/community/langchain_community/chat_message_histories