-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [Spanner] Exposing InstanceType in Instance configuration (to define PROVISIONED or FREE spanner instance) #7937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ISIONED or FREE spanner instance) feat: Exposing FreeInstanceMetadata in Instance configuration (to define the metadata related to FREE instance type) feat: Exposing storage_limit_per_processing_unit in InstanceConfig feat: Exposing QuorumType in InstanceConfig feat: Exposing FreeInstanceAvailability in InstanceConfig docs: A comment for method `ListInstanceConfigs` in service `InstanceAdmin` is changed docs: A comment for method `CreateInstanceConfig` in service `InstanceAdmin` is changed docs: A comment for method `UpdateInstanceConfig` in service `InstanceAdmin` is changed docs: A comment for method `ListInstanceConfigOperations` in service `InstanceAdmin` is changed docs: A comment for method `CreateInstance` in service `InstanceAdmin` is changed docs: A comment for method `UpdateInstance` in service `InstanceAdmin` is changed docs: A comment for method `CreateInstancePartition` in service `InstanceAdmin` is changed docs: A comment for method `UpdateInstancePartition` in service `InstanceAdmin` is changed docs: A comment for method `ListInstancePartitionOperations` in service `InstanceAdmin` is changed docs: A comment for method `MoveInstance` in service `InstanceAdmin` is changed docs: A comment for field `location` in message `.google.spanner.admin.instance.v1.ReplicaInfo` is changed docs: A comment for enum value `GOOGLE_MANAGED` in enum `Type` is changed docs: A comment for enum value `USER_MANAGED` in enum `Type` is changed docs: A comment for field `replicas` in message `.google.spanner.admin.instance.v1.InstanceConfig` is changed docs: A comment for field `optional_replicas` in message `.google.spanner.admin.instance.v1.InstanceConfig` is changed docs: A comment for field `base_config` in message `.google.spanner.admin.instance.v1.InstanceConfig` is changed docs: A comment for field `storage_utilization_percent` in message `.google.spanner.admin.instance.v1.AutoscalingConfig` is changed docs: A comment for enum `DefaultBackupScheduleType` is changed docs: A comment for enum value `NONE` in enum `DefaultBackupScheduleType` is changed docs: A comment for enum value `AUTOMATIC` in enum `DefaultBackupScheduleType` is changed docs: A comment for field `node_count` in message `.google.spanner.admin.instance.v1.Instance` is changed docs: A comment for field `processing_units` in message `.google.spanner.admin.instance.v1.Instance` is changed docs: A comment for field `default_backup_schedule_type` in message `.google.spanner.admin.instance.v1.Instance` is changed docs: A comment for message `CreateInstanceConfigRequest` is changed docs: A comment for field `instance_config` in message `.google.spanner.admin.instance.v1.CreateInstanceConfigRequest` is changed docs: A comment for message `UpdateInstanceConfigRequest` is changed docs: A comment for message `DeleteInstanceConfigRequest` is changed docs: A comment for field `filter` in message `.google.spanner.admin.instance.v1.ListInstanceConfigOperationsRequest` is changed docs: A comment for field `operations` in message `.google.spanner.admin.instance.v1.ListInstanceConfigOperationsResponse` is changed docs: A comment for field `node_count` in message `.google.spanner.admin.instance.v1.InstancePartition` is changed docs: A comment for field `processing_units` in message `.google.spanner.admin.instance.v1.InstancePartition` is changed docs: A comment for field `referencing_backups` in message `.google.spanner.admin.instance.v1.InstancePartition` is changed docs: A comment for field `parent` in message `.google.spanner.admin.instance.v1.ListInstancePartitionsRequest` is changed docs: A comment for field `unreachable` in message `.google.spanner.admin.instance.v1.ListInstancePartitionsResponse` is changed docs: A comment for field `filter` in message `.google.spanner.admin.instance.v1.ListInstancePartitionOperationsRequest` is changed docs: A comment for field `instance_partition_deadline` in message `.google.spanner.admin.instance.v1.ListInstancePartitionOperationsRequest` is changed docs: A comment for field `operations` in message `.google.spanner.admin.instance.v1.ListInstancePartitionOperationsResponse` is changed PiperOrigin-RevId: 706945550 Source-Link: googleapis/googleapis@3db0452 Source-Link: googleapis/googleapis-gen@6c42be3 Copy-Tag: eyJwIjoiU3Bhbm5lci8uT3dsQm90LnlhbWwiLCJoIjoiNmM0MmJlM2JmNTQ2ZjEwZjA5Y2FkOThiM2Y1NmY3N2MyNzFmYzhlMiJ9
trusted-contributions-gcf
bot
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Dec 17, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Dec 17, 2024
trusted-contributions-gcf
bot
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Dec 17, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Dec 17, 2024
bshaffer
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Exposing FreeInstanceMetadata in Instance configuration (to define the metadata related to FREE instance type)
feat: Exposing storage_limit_per_processing_unit in InstanceConfig
feat: Exposing QuorumType in InstanceConfig
feat: Exposing FreeInstanceAvailability in InstanceConfig
docs: A comment for method
ListInstanceConfigs
in serviceInstanceAdmin
is changeddocs: A comment for method
CreateInstanceConfig
in serviceInstanceAdmin
is changeddocs: A comment for method
UpdateInstanceConfig
in serviceInstanceAdmin
is changeddocs: A comment for method
ListInstanceConfigOperations
in serviceInstanceAdmin
is changeddocs: A comment for method
CreateInstance
in serviceInstanceAdmin
is changeddocs: A comment for method
UpdateInstance
in serviceInstanceAdmin
is changeddocs: A comment for method
CreateInstancePartition
in serviceInstanceAdmin
is changeddocs: A comment for method
UpdateInstancePartition
in serviceInstanceAdmin
is changeddocs: A comment for method
ListInstancePartitionOperations
in serviceInstanceAdmin
is changeddocs: A comment for method
MoveInstance
in serviceInstanceAdmin
is changeddocs: A comment for field
location
in message.google.spanner.admin.instance.v1.ReplicaInfo
is changeddocs: A comment for enum value
GOOGLE_MANAGED
in enumType
is changeddocs: A comment for enum value
USER_MANAGED
in enumType
is changeddocs: A comment for field
replicas
in message.google.spanner.admin.instance.v1.InstanceConfig
is changeddocs: A comment for field
optional_replicas
in message.google.spanner.admin.instance.v1.InstanceConfig
is changeddocs: A comment for field
base_config
in message.google.spanner.admin.instance.v1.InstanceConfig
is changeddocs: A comment for field
storage_utilization_percent
in message.google.spanner.admin.instance.v1.AutoscalingConfig
is changeddocs: A comment for enum
DefaultBackupScheduleType
is changeddocs: A comment for enum value
NONE
in enumDefaultBackupScheduleType
is changeddocs: A comment for enum value
AUTOMATIC
in enumDefaultBackupScheduleType
is changeddocs: A comment for field
node_count
in message.google.spanner.admin.instance.v1.Instance
is changeddocs: A comment for field
processing_units
in message.google.spanner.admin.instance.v1.Instance
is changeddocs: A comment for field
default_backup_schedule_type
in message.google.spanner.admin.instance.v1.Instance
is changeddocs: A comment for message
CreateInstanceConfigRequest
is changeddocs: A comment for field
instance_config
in message.google.spanner.admin.instance.v1.CreateInstanceConfigRequest
is changeddocs: A comment for message
UpdateInstanceConfigRequest
is changeddocs: A comment for message
DeleteInstanceConfigRequest
is changeddocs: A comment for field
filter
in message.google.spanner.admin.instance.v1.ListInstanceConfigOperationsRequest
is changeddocs: A comment for field
operations
in message.google.spanner.admin.instance.v1.ListInstanceConfigOperationsResponse
is changeddocs: A comment for field
node_count
in message.google.spanner.admin.instance.v1.InstancePartition
is changeddocs: A comment for field
processing_units
in message.google.spanner.admin.instance.v1.InstancePartition
is changeddocs: A comment for field
referencing_backups
in message.google.spanner.admin.instance.v1.InstancePartition
is changeddocs: A comment for field
parent
in message.google.spanner.admin.instance.v1.ListInstancePartitionsRequest
is changeddocs: A comment for field
unreachable
in message.google.spanner.admin.instance.v1.ListInstancePartitionsResponse
is changeddocs: A comment for field
filter
in message.google.spanner.admin.instance.v1.ListInstancePartitionOperationsRequest
is changeddocs: A comment for field
instance_partition_deadline
in message.google.spanner.admin.instance.v1.ListInstancePartitionOperationsRequest
is changeddocs: A comment for field
operations
in message.google.spanner.admin.instance.v1.ListInstancePartitionOperationsResponse
is changedPiperOrigin-RevId: 706945550
Source-Link: googleapis/googleapis@3db0452
Source-Link: https://github.com/googleapis/googleapis-gen/commit/6c42be3bf546f10f09cad98b3f56f77c271fc8e2
Copy-Tag: eyJwIjoiU3Bhbm5lci8uT3dsQm90LnlhbWwiLCJoIjoiNmM0MmJlM2JmNTQ2ZjEwZjA5Y2FkOThiM2Y1NmY3N2MyNzFmYzhlMiJ9