feat: Add the memory store component #7925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 16 region tags.
This comment is generated by snippet-bot.
|
bshaffer
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Hmm, this is a little weird to have two PRs for one component (e.g. #7924)
If you just add v1beta to MemoryStore/.OwlBot.yaml like this:
deep-copy-regex:
- source: /google/cloud/memorystore/(v1|v1beta)/.*-php/(.*)
dest: /owl-bot-staging/Memorystore/$1/$2
api-name: Memorystore
And run owlbot again as you did before creating the PR, then this component will include both versions.
bshaffer
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the memory store component
b/376713462