Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Logging] Add resource labels to logs from Cloud Run #7642

Merged
merged 6 commits into from
Dec 27, 2024

Conversation

kynx
Copy link
Contributor

@kynx kynx commented Sep 4, 2024

Fixes #3699

I've tried to match the labels and resource sections output when logging to stdout as closely as possible. The one thing missing is labels.container_name - I can't figure out where to get that value from.

@kynx kynx requested review from a team as code owners September 4, 2024 17:13
Copy link

google-cla bot commented Sep 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kynx
Copy link
Contributor Author

kynx commented Sep 17, 2024

@bshaffer Any chance of a review? Many thanks!

@kynx
Copy link
Contributor Author

kynx commented Nov 15, 2024

@bshaffer nag nag nag I know 😉 but does this stand a chance of making it into a release? It saves me from the truly ugly factories I use for constructing a logging client

@bshaffer bshaffer self-requested a review December 12, 2024 21:55
@bshaffer bshaffer self-assigned this Dec 12, 2024
@bshaffer
Copy link
Contributor

Hey @kynx Sorry! I don't know how I missed this. I'll take a look at it this week.

Logging/composer.json Outdated Show resolved Hide resolved
Core/src/Report/CloudRunJobMetadataProvider.php Outdated Show resolved Hide resolved
Core/src/Report/CloudRunServiceMetadataProvider.php Outdated Show resolved Hide resolved
Core/tests/Unit/Report/CloudRunJobMetadataProviderTest.php Outdated Show resolved Hide resolved
@bshaffer bshaffer enabled auto-merge (squash) December 27, 2024 20:53
@bshaffer bshaffer merged commit 06bd1bb into googleapis:main Dec 27, 2024
25 checks passed
@kynx
Copy link
Contributor Author

kynx commented Dec 27, 2024

Yay! Thanks @bshaffer !

@kynx kynx deleted the logging-metadata branch December 27, 2024 21:36
@bshaffer
Copy link
Contributor

Thank you for your contribution, @kynx! We will be releasing this early 2025 in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logging] Resource type and other metadata not auto-populated on Cloud Run
2 participants