-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [Logging] Add resource labels to logs from Cloud Run #7642
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
06ba585
to
56f50dc
Compare
aae6d7e
to
08f6599
Compare
@bshaffer Any chance of a review? Many thanks! |
@bshaffer nag nag nag I know 😉 but does this stand a chance of making it into a release? It saves me from the truly ugly factories I use for constructing a logging client |
Hey @kynx Sorry! I don't know how I missed this. I'll take a look at it this week. |
Yay! Thanks @bshaffer ! |
Thank you for your contribution, @kynx! We will be releasing this early 2025 in the next release. |
Fixes #3699
I've tried to match the
labels
andresource
sections output when logging tostdout
as closely as possible. The one thing missing islabels.container_name
- I can't figure out where to get that value from.