Skip to content

Commit

Permalink
chore!: promote CloudBuild to V1 (#7393)
Browse files Browse the repository at this point in the history
  • Loading branch information
bshaffer authored Jun 13, 2024
1 parent 8acc5d3 commit ed5264f
Show file tree
Hide file tree
Showing 145 changed files with 378 additions and 25,385 deletions.
2 changes: 1 addition & 1 deletion .repo-metadata-full.json
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@
"Build": {
"language": "php",
"distribution_name": "google/cloud-build",
"release_level": "preview",
"release_level": "stable",
"client_documentation": "https://cloud.google.com/php/docs/reference/cloud-build/latest",
"library_type": "GAPIC_AUTO",
"api_shortname": "cloudbuild"
Expand Down
2 changes: 1 addition & 1 deletion Build/.OwlBot.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
deep-copy-regex:
- source: /google/devtools/cloudbuild/(v1|v2)/.*-php/(.*)
- source: /google/devtools/cloudbuild/(v2)/.*-php/(.*)
dest: /owl-bot-staging/Build/$1/$2
api-name: Build
5 changes: 2 additions & 3 deletions Build/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,8 @@ on authenticating your client. Once authenticated, you'll be ready to start maki

### Version

This component is considered beta. As such, it should be expected to be mostly
stable and we're working towards a release candidate. We will address issues
and requests with a higher priority.
This component is considered GA (generally available). As such, it will not introduce backwards-incompatible changes in
any minor or patch releases. We will address issues and requests with the highest priority.

### Next Steps

Expand Down
Binary file removed Build/metadata/V1/Cloudbuild.php
Binary file not shown.
49 changes: 15 additions & 34 deletions Build/owlbot.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2021 Google LLC
# Copyright 2023 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -30,14 +30,7 @@
# Added so that we can pass copy_excludes in the owlbot_main() call
_tracked_paths.add(src)

php.owlbot_main(
src=src,
dest=dest,
copy_excludes=[
src / "**/[A-Z]*_*.php",
src / "**/*GrpcClient.php",
]
)
php.owlbot_main(src=src, dest=dest)

# remove class_alias code
s.replace(
Expand All @@ -48,28 +41,16 @@
+ "\n",
'')

### [START] protoc backwards compatibility fixes

# roll back to private properties.
s.replace(
"src/**/V*/**/*.php",
r"Generated from protobuf field ([^\n]{0,})\n\s{5}\*/\n\s{4}protected \$",
r"""Generated from protobuf field \1
*/
private $""")

# Replace "Unwrapped" with "Value" for method names.
s.replace(
"src/**/V*/**/*.php",
r"public function ([s|g]\w{3,})Unwrapped",
r"public function \1Value"
)

### [END] protoc backwards compatibility fixes

# fix relative cloud.google.com links
s.replace(
"src/**/V*/**/*.php",
r"(.{0,})\]\((/.{0,})\)",
r"\1](https://cloud.google.com\2)"
)
# format generated clients
subprocess.run([
'npm',
'exec',
'--yes',
'--package=@prettier/plugin-php@^0.16',
'--',
'prettier',
'**/Client/*',
'--write',
'--parser=php',
'--single-quote',
'--print-width=120'])
75 changes: 0 additions & 75 deletions Build/src/V1/ApprovalConfig.php

This file was deleted.

230 changes: 0 additions & 230 deletions Build/src/V1/ApprovalResult.php

This file was deleted.

Loading

0 comments on commit ed5264f

Please sign in to comment.