Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composer.json support for psr/cache v3 #390

Closed
wants to merge 1 commit into from

Conversation

pbowyer
Copy link

@pbowyer pbowyer commented Apr 1, 2022

This fixes the issue I reported at googleapis/google-cloud-php#5205.

When using PHP 8.1 it's becoming common to have packages that require psr/cache:^3 (in my case: symfony/cache-contracts:v3.0.0).

google/auth:v1.19.0 still requires psr/cache ^1.0|^2.0. This is preventing me from installing google/cloud-vision.

The only change with psr/cache:^3.0 is adding return types for PHP 8.0+, so you can support it as an option as it does not introduce any other changes.

@pbowyer pbowyer requested a review from a team as a code owner April 1, 2022 09:10
@google-cla
Copy link

google-cla bot commented Apr 1, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@pbowyer
Copy link
Author

pbowyer commented Apr 1, 2022

I've clicked the "rescan pull request" link after signing the CLA, submitted the form and... nothing 🤷‍♂️

@bshaffer
Copy link
Contributor

bshaffer commented Apr 4, 2022

This is being handled more robustly in #364

Please try using this branch by requiring it as an alias in composer.json and let me know if it works as you expect it to:

"google/auth": "dev-add-typed-cache-item as 1.20.0"

@bshaffer bshaffer closed this Apr 4, 2022
@bshaffer
Copy link
Contributor

This is now released in v1.20.0

@pbowyer
Copy link
Author

pbowyer commented Apr 25, 2022

Thanks, tested and confirmed working 👍

@pbowyer pbowyer deleted the patch-1 branch April 25, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants