This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
fix: use prophecy for php generated unit tests #3225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit 5 is still required by Google Cloud PHP since it has support for PHP 5. However in PHP 7.4 the PHPUnit mock builder raises the error
Function ReflectionType::__toString() is deprecated
, causing generated unit tests to fail.This change switches to the Prophecy mock library (bundled with PHPUnit), which has better support for PHP 7.4.