Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating iOS rootViewController use from loading time to showing time for fullscreen ads #1153

Merged
merged 15 commits into from
Aug 13, 2024

Conversation

LTPhantom
Copy link
Collaborator

Description

Showing fullscreen ads is a two step thing: load and show. On iOS, the rootViewController is required for showing ads but it was passed to ads when loading them, this caused some issues if the rootViewController was not valid somehow when trying to being shown. This PR updates the show functions for these ads to receive the rootViewController at show time.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@LTPhantom LTPhantom requested review from jjliu15 and luo86 August 8, 2024 23:14
@LTPhantom LTPhantom marked this pull request as ready for review August 9, 2024 20:36
Copy link
Collaborator

@jjliu15 jjliu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like iOS unit tests are failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants