Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and implementation of UMP SDK to 2.2.0/2.4.0 #1062

Merged
merged 27 commits into from
May 2, 2024
Merged

Update and implementation of UMP SDK to 2.2.0/2.4.0 #1062

merged 27 commits into from
May 2, 2024

Conversation

LTPhantom
Copy link
Collaborator

@LTPhantom LTPhantom commented Apr 18, 2024 •
edited
Loading

Description

Updated the UMP SDK version for Android and iOS and surfaced the missing methods on the dart layer. (GMA SDK for iOS already comes with the latest UMP SDK)

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@malandr2
Copy link
Collaborator

ACK: #1024

@LTPhantom LTPhantom marked this pull request as ready for review April 23, 2024 21:58
@malandr2 malandr2 self-requested a review April 24, 2024 16:54
@malandr2 malandr2 mentioned this pull request Apr 25, 2024
Closed
@malandr2
Copy link
Collaborator

ACK: #852

@Reprevise
Copy link

I definitely do appreciate a more Dart-like approach with these new APIs. Could there also be a loadAndShowPrivacyOptionsFormIfRequired? (maybe too long of a name)

jjliu15
jjliu15 reviewed Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@jjliu15 jjliu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note in the PR description that the iOS GMA version already has the required UMP version?

packages/google_mobile_ads/CHANGELOG.md Outdated Show resolved Hide resolved
packages/google_mobile_ads/ios/Classes/UserMessagingPlatform/FLTUserMessagingPlatformManager.m
result(@([UMPConsentInformation.sharedInstance canRequestAds]));
} else if ([call.method
isEqualToString:@"ConsentInformation#"
@"getPrivacyOptionsRequirementStatus"]) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be one line?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format tools changed it to two lines.

packages/google_mobile_ads/ios/Classes/UserMessagingPlatform/FLTUserMessagingPlatformManager.m
@@ -73,6 +92,24 @@ - (void)handleMethodCall:(FlutterMethodCall *_Nonnull)call
details:error.domain]);
}
}];
} else if ([call.method
isEqualToString:@"UserMessagingPlatform#"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@malandr2
Copy link
Collaborator

I definitely do appreciate a more Dart-like approach with these new APIs. Could there also be a loadAndShowPrivacyOptionsFormIfRequired? (maybe too long of a name)

There is a showPrivacyOptionsForm() API that can be triggered from a button in your app settings, for example. You can query getPrivacyOptionsRequirementStatus() to determine if you need to show this button or not.

@malandr2
Copy link
Collaborator

@LTPhantom iOS recently updated their UMP SDK version to 2.4.0 last week

@LTPhantom
Copy link
Collaborator Author

@LTPhantom iOS recently updated their UMP SDK version to 2.4.0 last week

Acknowledged. Current code in this PR should be compatible with it.

@LTPhantom LTPhantom changed the title Update and implementation of UMP SDK to 2.2.0/2.3.0 Update and implementation of UMP SDK to 2.2.0/2.4.0 Apr 30, 2024
malandr2
malandr2 approved these changes May 2, 2024
View reviewed changes
packages/google_mobile_ads/CHANGELOG.md Outdated Show resolved Hide resolved
packages/google_mobile_ads/CHANGELOG.md Outdated Show resolved Hide resolved
@LTPhantom LTPhantom merged commit d4071e1 into main May 2, 2024
32 checks passed
@malandr2 malandr2 mentioned this pull request May 6, 2024
Closed
@LTPhantom LTPhantom deleted the umpUpdate branch May 7, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luo86 luo86 luo86 approved these changes

@jjliu15 jjliu15 jjliu15 approved these changes

@malandr2 malandr2 malandr2 approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@srichakradhar srichakradhar Awaiting requested review from srichakradhar srichakradhar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LTPhantom @malandr2 @Reprevise @jjliu15 @luo86