Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demonstrate passing consent in offline conversion upload #829

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Demonstrate passing consent in offline conversion upload #829

merged 1 commit into from
Jan 11, 2024

Conversation

jradcliff
Copy link
Member

Ref: b/310739611

Change-Id: Ide8079c878fb3f5a5d5d7220e0e00a35d987d4f3

@jradcliff
Demonstrate passing consent in offline conversion upload
7a78308 
Change-Id: Ide8079c878fb3f5a5d5d7220e0e00a35d987d4f3
@jradcliff jradcliff requested a review from a team as a code owner January 11, 2024 15:15
bobhancockg
bobhancockg approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@bobhancockg bobhancockg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we require the user to supply up to 11 command line arguments, we should consider providing the option of supplying a TOML file.

BenRKarl
BenRKarl approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@BenRKarl BenRKarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that adding consent is not always required, otherwise the input argument would be required.

@BenRKarl BenRKarl merged commit 3000f18 into main Jan 11, 2024
3 of 4 checks passed
@BenRKarl BenRKarl deleted the ociconsent branch January 11, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobhancockg bobhancockg bobhancockg approved these changes

@BenRKarl BenRKarl BenRKarl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jradcliff @BenRKarl @bobhancockg