Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: separate error helpers #1014

Merged
merged 2 commits into from
Dec 21, 2024
Merged

refactor: separate error helpers #1014

merged 2 commits into from
Dec 21, 2024

Conversation

antongolub
Copy link
Collaborator

@antongolub antongolub commented Dec 21, 2024 •
edited
Loading

closes #964

This PR:

  • Improves error flow readability
  • Prepares the API to become public in future (if it makes sense)
  • Tests pass
  • Appropriate changes to README are included in PR

@antongolub antongolub requested a review from antonmedv December 21, 2024 14:06
@antongolub antongolub force-pushed the separate-error-helpers branch 3 times, most recently from b610736 to f10736c Compare December 21, 2024 14:53
@antongolub antongolub force-pushed the separate-error-helpers branch from f10736c to c869d1a Compare December 21, 2024 14:55
@antongolub antongolub force-pushed the separate-error-helpers branch from 0db212d to c64cb03 Compare December 21, 2024 15:06
@antongolub antongolub merged commit a69ddd4 into google:main Dec 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonmedv antonmedv Awaiting requested review from antonmedv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: separate error helpers
1 participant
@antongolub