Change reporting of load/store (read/write) errors from "unknown" to …

…something slightly more clear. (NFC) This is a follow up to cl/557880060. PiperOrigin-RevId: 563554467 Change-Id: I84a9107190f0d1664cef54d0c972468beab45851
google · Sep 7, 2023 · 6f14c73 · 6f14c73
1 parent 0ff2705
commit 6f14c73
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/tcmalloc/segv_handler.cc b/tcmalloc/segv_handler.cc
@@ -100,7 +100,7 @@ static void PrintStackTraceFromSignalHandler(void* context) {
 constexpr const char* WriteFlagToString(WriteFlag write_flag) {
   switch (write_flag) {
     case WriteFlag::Unknown:
-      return "(unknown)";
+      return "(read or write: indeterminate)";
     case WriteFlag::Read:
       return "(read)";
     case WriteFlag::Write:

diff --git a/tcmalloc/testing/memory_errors_test.cc b/tcmalloc/testing/memory_errors_test.cc
@@ -174,7 +174,7 @@ TEST_P(ReadWriteTcMallocTest, UnderflowDetected) {
 #if !defined(__riscv)
                    write_test ? "\\(write\\)" : "\\(read\\)",
 #else
-                   "\\(unknown\\)",
+                   "\\(read or write: indeterminate\\)";
 #endif
                    " occurs in thread [0-9]+ at");
   EXPECT_DEATH(RepeatUnderflow(), expected_output);
@@ -205,7 +205,7 @@ TEST_P(ReadWriteTcMallocTest, OverflowDetected) {
 #if !defined(__riscv)
                    write_test ? "\\(write\\)" : "\\(read\\)",
 #else
-                   "\\(unknown\\)",
+                   "\\(read or write: indeterminate\\)";
 #endif
                    " occurs in thread [0-9]+ at");
   EXPECT_DEATH(RepeatOverflow(), expected_output);
@@ -231,7 +231,7 @@ TEST_P(ReadWriteTcMallocTest, UseAfterFreeDetected) {
 #if !defined(__riscv)
                    write_test ? "\\(write\\)" : "\\(read\\)",
 #else
-                   "\\(unknown\\)",
+                   "\\(read or write: indeterminate\\)";
 #endif
                    " occurs in thread [0-9]+ at");
   EXPECT_DEATH(RepeatUseAfterFree(), expected_output);